fix: Allowed 404 to fall through axios during import flow #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick and
srinaath
as code owners
a-b-r-o-w-n
approved these changes
Nov 11, 2020
cwhitten
changed the title
Merged
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 16, 2020
* settingsPage: (22 commits) Refactoring function calls fix: remove special case for single-bot view in tree (microsoft#4803) fix bug fix UT code refine Removed other languages for now. (microsoft#4789) Made the default width for the property editor wider (microsoft#4788) pass csrf token to plugin hosts (microsoft#4787) Updated disability styles chore: rebase main onto bot-projects feature branch (microsoft#4780) fix: zip file can not be deleted (microsoft#4760) Remove enforce auto end dialog for skill bots (microsoft#4440) Several PVA integration improvements / bug fixes (microsoft#4776) Updated strings from building (microsoft#4762) feat: Implement pull from publish target (microsoft#4768) fix: Allowed 404 to fall through axios during import flow (microsoft#4770) increase unit tests timeout to 30 min (microsoft#4764) feat: Allow importing bot content from an external source (microsoft#4751) Localized resource files from OneLocBuild (microsoft#4730) force node extensions to only require commonjs (microsoft#4755) ...
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the import flow was using the standard browser
fetchAPI, and then switched toaxioswhich actually throws on all non-200 HTTP responses.There was code that was expecting a 404 from the
getAliasAPI to fall through and not throw, so I've bypassed 404 in axios' built-in status number validation.Task Item
#minor